Page 1 of 1

Linux kernel 5.18

PostPosted: Thu Jun 09, 2022 9:08 pm
by hasecomp
Please allow me to mention that there are issues with the Open Source Linux Driver when using Linux kernel 5.18.

Linux 5.18.1-arch1-1:

/home/andre/media_build/v4l/msi001.c:504:27: error: initialization of 'void (*)(struct spi_device *)' from incompatible pointer type 'int (*)(struct spi_device *)' [-Werror=incompatible-pointer-types]
504 | .remove = msi001_remove,
| ^~~~~~~~~~~~~
/home/andre/media_build/v4l/msi001.c:504:27: note: (near initialization for 'msi001_driver.remove')
cc1: some warnings being treated as errors
make[3]: *** [scripts/Makefile.build:288: /home/andre/media_build/v4l/msi001.o] Error 1
make[3]: *** Waiting for unfinished jobs....
make[2]: *** [Makefile:1834: /home/andre/media_build/v4l] Error 2
make[2]: Leaving directory '/usr/lib/modules/5.18.1-arch1-1/build'
make[1]: *** [Makefile:53: default] Error 2
make[1]: Leaving directory '/home/andre/media_build/v4l'
make: *** [Makefile:26: all] Error 2


Linux 5.18.2-arch1-1:

/home/andre/media_build/v4l/msi001.c:504:27: error: initialization of 'void (*)(struct spi_device *)' from incompatible pointer type 'int (*)(struct spi_device *)' [-Werror=incompatible-pointer-types]
504 | .remove = msi001_remove,
| ^~~~~~~~~~~~~
/home/andre/media_build/v4l/msi001.c:504:27: note: (near initialization for 'msi001_driver.remove')
cc1: some warnings being treated as errors
make[3]: *** [scripts/Makefile.build:288: /home/andre/media_build/v4l/msi001.o] Error 1
make[3]: *** Waiting for unfinished jobs....
make[2]: *** [Makefile:1834: /home/andre/media_build/v4l] Error 2
make[2]: Leaving directory '/usr/lib/modules/5.18.2-arch1-1/build'
make[1]: *** [Makefile:53: default] Error 2
make[1]: Leaving directory '/home/andre/media_build/v4l'
make: *** [Makefile:26: all] Error 2

As far as I'm concerned, you need not hurry with submitting an update of the driver, since I downgraded my Arch Linux to Linux kernel 5.17.9.

My TBS card is a TBS6281SE, but this is probably not relevant in this context.

Kind regards,
Andre Hasekamp.

Re: Linux kernel 5.18

PostPosted: Thu Jun 16, 2022 2:41 pm
by zhangchao
hi,
please add skype jack_2431. or write email to support@tbsdtv.com
best regards!

Re: Linux kernel 5.18

PostPosted: Thu Jun 23, 2022 4:51 pm
by fe31nz
There is a patch to fix this, but it has not been merged into the main code yet. See:

https://github.com/tbsdtv/linux_media/issues/286#issuecomment-1163438727

Re: Linux kernel 5.18

PostPosted: Wed Jul 06, 2022 7:22 pm
by pchristy
Build still fails on Slackware-current:
Code: Select All Code
Entering directory '~/Build/TBS/media_build/linux'
rm -rf drivers include sound mm .patches_applied .linked_dir .git_log.md5 git_log kernel_version.h
lsdiff: error while loading shared libraries: libpcre2-posix.so.2: cannot open shared object file: No such file or directory


Slackware-current uses libpcre2-posix.so.3. This issue has been present for a long time, and I have been using the CrazyCat fork, which worked well up to kernel 5.18. I haven't been able to work out how to apply the patch to that fork (which actually produces a much cleaner install), and CC seems to have gone very quiet. I think he is in Ukraine somewhere, so perhaps understandable...!

--
Pete

Re: Linux kernel 5.18

PostPosted: Fri Jul 08, 2022 4:50 am
by crazycat
First try 5.18 support in mainline media_build - https://git.linuxtv.org/media_build.git
Look like this stll broken, so i can't merge it now.

Re: Linux kernel 5.18

PostPosted: Mon Jul 11, 2022 3:06 am
by mollcons
I am running Fedora 36 and now on kernel 5.18.

I have just tried to rebuild my Tbsdtv drivers and get the following error:
/export/root/media_build/v4l/msi001.c:504:27: error: initialization of 'void (*)(struct spi_device *)' from incompatible pointer type 'int (*)(struct spi_device *)' [-Werror=incompatible-pointer-types]
504 | .remove = msi001_remove,
| ^~~~~~~~~~~~~
/export/root/media_build/v4l/msi001.c:504:27: note: (near initialization for 'msi001_driver.remove')
cc1: some warnings being treated as errors

What is the solution?

Re: Linux kernel 5.18

PostPosted: Sun Jul 17, 2022 3:04 pm
by pchristy
mollcons Wrote:What is the solution?


Join the club! At present there doesn't seem to be a solution!

Luckily, I kept an old kernel as a spare, and need to boot into that if I need the TV functions - which is a pain in the posterior!

--
Pete

Re: Linux kernel 5.18

PostPosted: Mon Jul 18, 2022 4:41 am
by crazycat
tbsdtv/media_build and tbsdtv/linux_media updated
must be compatible with 4.4 - 5.18 kernels

Re: Linux kernel 5.18

PostPosted: Thu Jul 21, 2022 4:25 pm
by pchristy
Built and tested successfully on 5.18.10, using CC's fork build (which gets around the libpcre3-posix issue in Slackware).

CC: Many thanks for your efforts!

--
Pete

Re: Linux kernel 5.18

PostPosted: Wed Aug 03, 2022 11:00 pm
by smorgan
Although the SPI related errors were fixed in the recent update, I'm still unable to build against 5.18.13 on Fedora. I get the following error:

Code: Select All Code
media_build/v4l/mc-entity.c:829:14: error: implicit declaration of function 'media_entity_is_streaming'; did you mean 'media_entity_setup_link'? [-Werror=implicit-function-declaration]
  829 |             (media_entity_is_streaming(source) ||
      |              ^~~~~~~~~~~~~~~~~~~~~~~~~
      |              media_entity_setup_link


If I start disabling the media control sub-system then more build failures follow.